I don’t think he has “ruined” his legacy with that, only probably cost himself the slam record.You keep mentioning the head to head with Nadal but ignore the fact that Federer's head to head against Djokovic only becomes worse. I think it is safe to say that at least in Wimbledon 2019 Federer clearly lost much more than he won. Some Federer fans just mention that semifinal against Nadal to feel better about the horrible loss in the final. You can call me a hater for writing this, that's your opinion. Maybe you think I'm also a Nadal hater because I think he hurts his legacy with all these losses now?
If he had retired, he would be 2nd and almost 3rd now anyway.