Federer until 2010 atleast was very good. This nonsense of him being a crickety old man already at 26, is even more ridiculous than those who say Nadal is fading at 25 (keep in mind as we always reminded by ****s Nadal was an early bloomer, Federer was a super late bloomer which explains away all his defeats until turning 23). Federer from 2008-January 2010 reached the finals of 8 of 9 slams, winning 4 of them. In 2010 he won Australian Open, WTF, Cincinnati Masters, reached 2 other Masters finals, had match points to be in the U.S Open final.
He only faded slightly and the competition had gotten alot stronger than just facing Hewitt, Roddick, mid 30s Agassi, or sometimes Baghdatis, Gonzalez, washed up Philippoussis in virtually every Australian, Wimbledon, and U.S Open final. Instead the two pigeons Hewitt and Roddick were replaced with Nadal and Djokovic, needless to say an enormous upgrade, while the likes of regular top 5 and sometimes top 3 players of the Federer era such as Blake and Ljubicic were replaced by people like Murray and Soderling. This year, and starting last year after Australia, is the first time he truly regressed alot.